feat: add formatPhone#155
feat: add formatPhone#155linconkusunoki wants to merge 4 commits intobrazilian-utils:mainfrom linconkusunoki:main
Conversation
Codecov Report
@@ Coverage Diff @@
## main #155 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 51 51
Lines 938 955 +17
Branches 113 122 +9
=========================================
+ Hits 938 955 +17
Continue to review full report at Codecov.
|
pedrovsp
left a comment
There was a problem hiding this comment.
I think you could add a few more test cases, I suggested two examples in the test file.
|
Hello nice MR @linconkusunoki and thanks @pedrovsp for the review! Another thing that I think could be improved is the removal of the config param... I know that I've suggested this but looking at the code and the test cases, maybe its better to just format the prefix when receiving this prefix. Something like: What do you think about it? |
|
hey guys thanks for the feedback and sorry for the late, I'll work on these changes |
|
I like the idea of receiving the phone number and format the country code if it is present (eg. length > 11). |
|
Hello guys, do you need some help? |
|
hey @hyanmandian for me it's ok if anyone wants to get this task #186, maybe close this PR and open another one? |
|
Fala @linconkusunoki tudo certim? Entao, to fazendo um refactoring na lib e vou incluir essa mudanca la! Sinta-se a vontade a fazer o review se quiser! Assim q eu terminar o refactoring, vou te adicionar como contribuidor! |
related: #146